Draft: feat(ui): render insurance additional products generically on risk detail @navratilda · 2026-06-22

Merge Request Info

Summary

This MR generalizes vehicle additional-product rendering across quick overview, scope-of-insurance rows, and risk-detail tabs, including Home Service detail rendering. It also regenerates the FE API client, adds backend seed/mapping support, and covers the new behavior with focused unit and Playwright tests. The implementation looks directionally sound; only small FE lint/style cleanups remain.

Review Verdict

APPROVE WITH MINOR SUGGESTIONS

No blocking correctness or contract-regeneration issue found. Please clean up the lint-level cn(...) pattern before merge.

Existing Review Threads

• general (@coderabbitai): "Review skipped. Draft detected." - open.

Changed Files Overview

Critical Issues

None.

Warnings

Issue 1: cn(...) uses the banned falsy-class pattern

• File: frontend/apps/broker/src/features/insurance-subjects/insurance-subject-scope-of-insurance-card.tsx:112
• Severity: Warning
• Category: Frontend lint
• Description: The static scanner flags cn(data.length === 0 && 'py-8'). The local FE rulebook treats this as the no-classname-ternary pattern: use object-form cn(base, { className: condition }) instead of passing a boolean/string expression.
• Suggestion: Keep the conditional class but express it in the lint-approved form.

// Current
<CardContent className={cn(data.length === 0 && 'py-8')}>

// Suggested
<CardContent className={cn({ 'py-8': data.length === 0 })}>

Suggestions

• frontend/apps/broker/src/features/insurance-subjects/insurance-subject-scope-of-insurance-card.tsx:192: Use size-6 for the square IconArrowRight instead of paired w-6 h-6, matching the local icon-size convention. The same pre-existing pattern appears elsewhere in this file, so this can be cleaned up consistently.
• frontend/apps/broker/src/features/insurance-scope/additional-products/home-service-detail.tsx:55: Prefer stable data-derived keys over crypto.randomUUID() for repeated Home Service rows/sections. The current useMemo limits churn, but a key from sectionKey plus the row identifier/value would be simpler and deterministic.

Positive Highlights

• FE Kubb client regeneration is present with the backend contract change.
• Home Service grouping and translation behavior has focused unit coverage.
• The E2E tests use central locators/test data and assert seeded values rather than only checking that a card exists.
• The backend ACL keeps locale dictionaries on cs / sk / en, matching the brand locale type.

Testing Assessment

Checklist

Backend

• Core props are required OR nullable
• Reuses shared Core enums/types for institution and risk type
• DateTimeOffset values normalized at ACL boundary
• Generated FE Kubb client regenerated

Frontend

• Paraglide m imports used directly
• Design-token colors used for new UI
• @tabler/icons-react used for new icons
• Generated API types used instead of hand-written HTTP types
• No GritQL-banned class composition patterns

Testing

• New unit tests added for mapping/rendering helpers
• E2E uses central e2e/data/locators/*
• E2E asserts real seeded values
• No networkidle or fixed sleeps in the new tests

Infra / cross-cutting

• Generated FE Kubb client regenerated *** End Patch